gtk4.git
5 years agoAdwaita: fix active state for radios & checkboxes
Jakub Steiner [Wed, 15 Apr 2020 11:34:41 +0000 (13:34 +0200)]
Adwaita: fix active state for radios & checkboxes

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2493

5 years agoMerge branch 'emoji-keynav' into 'master'
Matthias Clasen [Wed, 15 Apr 2020 05:34:03 +0000 (05:34 +0000)]
Merge branch 'emoji-keynav' into 'master'

Emoji keynav

See merge request GNOME/gtk!1687

5 years agoMerge branch 'arnaudb/fix-typo' into 'master'
Matthias Clasen [Tue, 14 Apr 2020 19:27:34 +0000 (19:27 +0000)]
Merge branch 'arnaudb/fix-typo' into 'master'

Fix typo in IconTheme.

See merge request GNOME/gtk!1686

5 years agoemojichooser: link sections for keynav
Matthias Clasen [Tue, 14 Apr 2020 12:40:08 +0000 (08:40 -0400)]
emojichooser: link sections for keynav

Make Up/Down jump between sections in the Emoji grid.

5 years agoflowbox: Add a private api to disable move-cursor
Matthias Clasen [Tue, 14 Apr 2020 19:03:57 +0000 (15:03 -0400)]
flowbox: Add a private api to disable move-cursor

Without this, it seems impossible to make cross-section
keynav in the Emoji chooser work. I've tried, but got
lost between the focus, grab_focus, move_cursor and
keynav-failed vfuncs and signals, and their competing
implementations GtkFlowBox and GtkEmojiChooser.

5 years agoflowbox: Remove can-focus handling
Matthias Clasen [Tue, 14 Apr 2020 17:29:49 +0000 (13:29 -0400)]
flowbox: Remove can-focus handling

With the new meaning of can-focus, this doesn't make
sense anymore.

5 years agoFix typo in IconTheme.
Arnaud Bonatti [Tue, 14 Apr 2020 18:43:02 +0000 (20:43 +0200)]
Fix typo in IconTheme.

The add_search_path() method was
using the resource_path property
in place of the search_path one.

5 years agoemojichooser: Improve keynav, again
Matthias Clasen [Tue, 14 Apr 2020 01:44:09 +0000 (21:44 -0400)]
emojichooser: Improve keynav, again

When the focus is moved to one of the Emoji children,
scroll it into view.

5 years agoemojichooser: Improve keynav
Matthias Clasen [Tue, 14 Apr 2020 01:43:27 +0000 (21:43 -0400)]
emojichooser: Improve keynav

Add an action to scroll to the next or previous section,
and bind it to Ctrl-n/Ctrl-p.

5 years agoUpdate Turkish translation
Emin Tufan Çetin [Tue, 14 Apr 2020 16:09:12 +0000 (16:09 +0000)]
Update Turkish translation

5 years agoUpdate Turkish translation
Sabri Ünal [Tue, 14 Apr 2020 16:01:18 +0000 (16:01 +0000)]
Update Turkish translation

5 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Tue, 14 Apr 2020 14:07:54 +0000 (14:07 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

Matthiasc/for master

See merge request GNOME/gtk!1685

5 years agoMerge branch 'library-versioning' into 'master'
Matthias Clasen [Tue, 14 Apr 2020 14:00:42 +0000 (14:00 +0000)]
Merge branch 'library-versioning' into 'master'

build: Prepare library versioning

See merge request GNOME/gtk!1684

5 years agobuild: Prepare library versioning
Matthias Clasen [Tue, 14 Apr 2020 13:15:31 +0000 (09:15 -0400)]
build: Prepare library versioning

Set version and soversion separately for the library.
When we do the 4.0 release, we will set:

gtk_soversion = '1'
gtk_library_version = '1.0.0'

See https://gitlab.gnome.org/GNOME/gtk/-/issues/1963

6 years agoappchooserwidget: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 23:24:13 +0000 (19:24 -0400)]
appchooserwidget: Drop the Private struct

6 years agolockbutton: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 23:17:11 +0000 (19:17 -0400)]
lockbutton: Drop the Private struct

6 years agoexpander: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 22:19:55 +0000 (18:19 -0400)]
expander: Drop the Private struct

6 years agocolorswatch: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 22:10:22 +0000 (18:10 -0400)]
colorswatch: Drop the Private struct

6 years agoMerge branch 'wip/matthiasc/monitor-signals' into 'master'
Matthias Clasen [Mon, 13 Apr 2020 23:25:55 +0000 (23:25 +0000)]
Merge branch 'wip/matthiasc/monitor-signals' into 'master'

Add enter/leave signals for monitors

See merge request GNOME/gtk!1680

6 years agoMerge branch 'use-gtk-doc-for-gtk4' into 'master'
Matthias Clasen [Mon, 13 Apr 2020 23:21:57 +0000 (23:21 +0000)]
Merge branch 'use-gtk-doc-for-gtk4' into 'master'

Use gtk-doc from the gtk-doc-for-gtk4 branch

See merge request GNOME/gtk!1683

6 years agoAlways use gtk-doc as a subproject for now
Matthias Clasen [Mon, 13 Apr 2020 20:40:57 +0000 (16:40 -0400)]
Always use gtk-doc as a subproject for now

We need the support for actions syntax, among
other things.

6 years agoSwitch the gtk-doc subproject to the gtk-doc-for-gtk4 branch
Matthias Clasen [Mon, 13 Apr 2020 20:40:11 +0000 (16:40 -0400)]
Switch the gtk-doc subproject to the gtk-doc-for-gtk4 branch

This branch contains assorted fixes and enhancements that
are needed to build the gtk4 docs.

6 years agoRemove the blacklist list in convert-emoji.c since now it is supported
Mathieu H [Mon, 13 Apr 2020 15:27:40 +0000 (15:27 +0000)]
Remove the blacklist list in convert-emoji.c since now it is supported

6 years agoUpdated Lithuanian translation
Aurimas Černius [Mon, 13 Apr 2020 19:43:30 +0000 (22:43 +0300)]
Updated Lithuanian translation

6 years agosurface: Document coordinate systems a bit
Matthias Clasen [Mon, 13 Apr 2020 13:29:11 +0000 (09:29 -0400)]
surface: Document coordinate systems a bit

Mention that sizes are in application pixels.

Also, remove some X11-specific docs.

6 years agoinspector: Show scales other than 2
Matthias Clasen [Mon, 13 Apr 2020 13:17:46 +0000 (09:17 -0400)]
inspector: Show scales other than 2

We were hardcoding that monitor scales can only be
1 or 2. Not true.

6 years agowayland: emit ::enter/leave-monitor
Matthias Clasen [Wed, 29 Nov 2017 03:37:42 +0000 (22:37 -0500)]
wayland: emit ::enter/leave-monitor

These signals directly mirror the surface_enter/leave events
of the Wayland protocol, so this is very staightforward.

6 years agogdk: Add ::enter/leave-monitor signals
Matthias Clasen [Wed, 29 Nov 2017 03:36:17 +0000 (22:36 -0500)]
gdk: Add ::enter/leave-monitor signals

These are useful to keep track of what monitors a window is on.

6 years agoMerge branch 'modal-buttons' into 'master'
Matthias Clasen [Mon, 13 Apr 2020 11:15:14 +0000 (11:15 +0000)]
Merge branch 'modal-buttons' into 'master'

Modal buttons

See merge request GNOME/gtk!1679

6 years agoappchooserbutton: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 04:46:00 +0000 (00:46 -0400)]
appchooserbutton: Drop the Private struct

6 years agoAdd a GtkAppChooserButton:modal property
Matthias Clasen [Mon, 13 Apr 2020 04:43:19 +0000 (00:43 -0400)]
Add a GtkAppChooserButton:modal property

Nowadays, dialogs are expected to be attached, typically,
and that only happens when they are marked as modal.

6 years agofontbutton: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 04:32:50 +0000 (00:32 -0400)]
fontbutton: Drop the Private struct

6 years agoAdd a GtkFontButton:modal property
Matthias Clasen [Mon, 13 Apr 2020 04:28:34 +0000 (00:28 -0400)]
Add a GtkFontButton:modal property

Nowadays, dialogs are expected to be attached, typically,
and that only happens when they are marked as modal.

6 years agocolorbutton: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 04:28:11 +0000 (00:28 -0400)]
colorbutton: Drop the Private struct

6 years agoAdd a GtkColorButton:modal property
Matthias Clasen [Mon, 13 Apr 2020 04:17:00 +0000 (00:17 -0400)]
Add a GtkColorButton:modal property

Nowadays, dialogs are expected to be attached, typically,
and that only happens when they are marked as modal.

6 years agofilechooserbutton: Make dialog modal by default
Matthias Clasen [Mon, 13 Apr 2020 04:12:30 +0000 (00:12 -0400)]
filechooserbutton: Make dialog modal by default

This is the expected behavior, so default to it.

6 years agofilechooserbutton: Drop the Private struct
Matthias Clasen [Mon, 13 Apr 2020 03:57:49 +0000 (23:57 -0400)]
filechooserbutton: Drop the Private struct

6 years agoAdd a GtkFileChooserButton:modal property
Matthias Clasen [Mon, 13 Apr 2020 03:45:03 +0000 (23:45 -0400)]
Add a GtkFileChooserButton:modal property

Nowadays, dialogs are expected to be attached, typically,
and that only happens when they are marked as modal.

6 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Mon, 13 Apr 2020 03:42:26 +0000 (03:42 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

Adwaita: visible focus outline for color swatches

See merge request GNOME/gtk!1678

6 years agowindow: Make resize cursors work for modal dialogs
Matthias Clasen [Mon, 13 Apr 2020 02:18:50 +0000 (22:18 -0400)]
window: Make resize cursors work for modal dialogs

We were inadvertedly not letting the grab_widget determine
a cursor. This was showing up as resize cursors not appearing.

6 years agogtk-demo: Group the OpenGL demos
Matthias Clasen [Mon, 13 Apr 2020 01:58:07 +0000 (21:58 -0400)]
gtk-demo: Group the OpenGL demos

6 years agogtk-demo: Add a gears demo
Matthias Clasen [Mon, 13 Apr 2020 00:39:03 +0000 (20:39 -0400)]
gtk-demo: Add a gears demo

6 years agoAdwaita: visible focus outline for color swatches
Matthias Clasen [Mon, 13 Apr 2020 00:13:16 +0000 (20:13 -0400)]
Adwaita: visible focus outline for color swatches

Make the focus outline for color swatches visible
again.

6 years agoMerge branch 'arnaudb/better-substitution' into 'master'
Matthias Clasen [Sun, 12 Apr 2020 22:53:54 +0000 (22:53 +0000)]
Merge branch 'arnaudb/better-substitution' into 'master'

Fix some gtk-builder-tool substitutions.

See merge request GNOME/gtk!1675

6 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Sun, 12 Apr 2020 22:07:20 +0000 (22:07 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

text: Fix placing the cursor on click

See merge request GNOME/gtk!1673

6 years agotext: Be more careful with cached layouts
Matthias Clasen [Sun, 12 Apr 2020 19:12:37 +0000 (15:12 -0400)]
text: Be more careful with cached layouts

If we call any functions that may call ensure_layout
themeselves, we risk having the cached layout pulled
out from underneath. Better play it safe and take a
reference.

6 years agowindow: Cosmetic cleanup
Matthias Clasen [Sun, 12 Apr 2020 17:33:32 +0000 (13:33 -0400)]
window: Cosmetic cleanup

Use a convenience function to get the current event time.

6 years agotextview: Fix an erroneous unref
Matthias Clasen [Sun, 12 Apr 2020 17:32:57 +0000 (13:32 -0400)]
textview: Fix an erroneous unref

This was left behind by accident in 0ee58e9ef41830e.

6 years agoCoding style improvements.
Arnaud Bonatti [Sun, 12 Apr 2020 19:21:24 +0000 (21:21 +0200)]
Coding style improvements.

6 years agoFix tests for margin-left and margin-right.
Arnaud Bonatti [Sun, 12 Apr 2020 16:41:42 +0000 (18:41 +0200)]
Fix tests for margin-left and margin-right.

6 years agoReplace also margin-left and margin-right.
Arnaud Bonatti [Sun, 12 Apr 2020 16:40:14 +0000 (18:40 +0200)]
Replace also margin-left and margin-right.

6 years agoFix tests for hexpand and vexpand.
Arnaud Bonatti [Sun, 12 Apr 2020 16:49:11 +0000 (18:49 +0200)]
Fix tests for hexpand and vexpand.

6 years agoFix --3to4 tests for margin substitution.
Arnaud Bonatti [Sun, 12 Apr 2020 16:38:13 +0000 (18:38 +0200)]
Fix --3to4 tests for margin substitution.

6 years agoFix a gtk-builder-tool substitution.
Arnaud Bonatti [Sun, 12 Apr 2020 15:32:40 +0000 (17:32 +0200)]
Fix a gtk-builder-tool substitution.

The margin-left and margin-right properties have been
removed in favor of margin-start and margin-end ones.

6 years agowayland: Avoid criticals when unsetting transient parents
Matthias Clasen [Sun, 12 Apr 2020 16:10:18 +0000 (12:10 -0400)]
wayland: Avoid criticals when unsetting transient parents

Must not check the display when parent is NULL.

6 years agostylecontext: Respect cursor aspect ratio everywhere
Matthias Clasen [Sun, 12 Apr 2020 15:27:56 +0000 (11:27 -0400)]
stylecontext: Respect cursor aspect ratio everywhere

We were using the new cursor aspect ratio setting in
the snapshotting code, but not in gtk_render_insertion_cursor.

Make them both behave the same.

6 years agoreftest: get backtraces
Matthias Clasen [Sun, 12 Apr 2020 14:40:07 +0000 (10:40 -0400)]
reftest: get backtraces

In the hope of making ci-only failures less of a black hole,
add a backtrace to the messsage for criticals.

This could eventually go into GLib (pass backtrace symbols along
as a log field for criticals), but for now this will do.

6 years agoMerge branch 'ci-error-report' into 'master'
Emmanuele Bassi [Sun, 12 Apr 2020 13:58:55 +0000 (13:58 +0000)]
Merge branch 'ci-error-report' into 'master'

ci: Count 'ERROR' codes as failures

See merge request GNOME/gtk!1674

6 years agoci: Count 'ERROR' codes as failures
Emmanuele Bassi [Sun, 12 Apr 2020 13:28:59 +0000 (14:28 +0100)]
ci: Count 'ERROR' codes as failures

Otherwise they'll be dropped from our reports.

6 years agotext: Fix placing the cursor on click
Matthias Clasen [Sun, 12 Apr 2020 13:16:51 +0000 (09:16 -0400)]
text: Fix placing the cursor on click

Commit c297d45b8a19d84e0 accidentally removed the
check for the right modifier mask, causing us to
always extend the selection.

6 years agoUpdate Japanese translation
sicklylife [Sun, 12 Apr 2020 08:53:45 +0000 (08:53 +0000)]
Update Japanese translation

6 years agoUpdate POTFILES.in
Piotr Drąg [Sun, 12 Apr 2020 08:45:54 +0000 (10:45 +0200)]
Update POTFILES.in

6 years agoMerge branch 'show-uri-async' into 'master'
Matthias Clasen [Sun, 12 Apr 2020 02:27:38 +0000 (02:27 +0000)]
Merge branch 'show-uri-async' into 'master'

Redo gtk_show_uri_on_window

See merge request GNOME/gtk!1671

6 years agogtk: Port all users to the new gtk_show_uri()
Matthias Clasen [Sun, 12 Apr 2020 01:58:19 +0000 (21:58 -0400)]
gtk: Port all users to the new gtk_show_uri()

We were only handling the error in one place anyway.

6 years agoRedo gtk_show_uri_on_window
Matthias Clasen [Sun, 12 Apr 2020 01:56:32 +0000 (21:56 -0400)]
Redo gtk_show_uri_on_window

Make this a full async function, and add a simple wrapper.

Call gtk_show_uri_full() if you need control over the
results, and use gtk_show_uri() if you are fine with
ignoring any errors.

6 years agoMerge branch 'current-event-apis' into 'master'
Matthias Clasen [Sun, 12 Apr 2020 00:24:14 +0000 (00:24 +0000)]
Merge branch 'current-event-apis' into 'master'

Current event apis

See merge request GNOME/gtk!1668

6 years agoDrop gtk_get_current_ apis
Matthias Clasen [Sat, 11 Apr 2020 19:04:52 +0000 (15:04 -0400)]
Drop gtk_get_current_ apis

We have event controller apis to replace these.
There is one remaining use of gtk_get_current_event_time
in gtkwindow.c, so we can't drop the implementation yet.

Add a section in the migration guide for this.

6 years agotests: Stop using gtk_get_current_ apis
Matthias Clasen [Sat, 11 Apr 2020 18:54:08 +0000 (14:54 -0400)]
tests: Stop using gtk_get_current_ apis

Replace these by equivalent event controller
apis where needed.

6 years agogtk: Port widgets away from gtk_get_current_ apis
Matthias Clasen [Sat, 11 Apr 2020 18:52:43 +0000 (14:52 -0400)]
gtk: Port widgets away from gtk_get_current_ apis

This commit handles complicated cases where we selections.
We handle this by adding extend and modify parameters to
the ::move-cursor signals, and adjust the bindings
accordingly.

6 years agogtk: Port widgets away from gtk_get_current_ apis
Matthias Clasen [Sat, 11 Apr 2020 18:58:15 +0000 (14:58 -0400)]
gtk: Port widgets away from gtk_get_current_ apis

Use the event controller equivalents where needed.
This commit covers the simple cases.

6 years agoAdd gtk_event_controller_get_current_event[_state]
Matthias Clasen [Sat, 11 Apr 2020 16:40:21 +0000 (12:40 -0400)]
Add gtk_event_controller_get_current_event[_state]

For now these are private, to replace internal uses
of gtk_get_current_event[_state], but we may want to
make them public.

6 years agogtk: Just use current time for showing urls
Matthias Clasen [Sat, 11 Apr 2020 17:10:20 +0000 (13:10 -0400)]
gtk: Just use current time for showing urls

We don't really have an event anywhere close in most
cases, and we already pass GDK_CURRENT_TIME in half
the cases anyway.

If we want to be serious about this, we need to pass
the event itself, since future focus-stealing protocols
may not rely on just a timestamp.

6 years agoentrycompletion: Remove an unused field
Matthias Clasen [Sat, 11 Apr 2020 17:09:45 +0000 (13:09 -0400)]
entrycompletion: Remove an unused field

No point in storing a device that is never used.

6 years agoMerge branch 'matthiasc/for-master' into 'master'
Matthias Clasen [Sat, 11 Apr 2020 21:16:11 +0000 (21:16 +0000)]
Merge branch 'matthiasc/for-master' into 'master'

broadway: Fix the build

See merge request GNOME/gtk!1670

6 years agobroadway: Fix the build
Matthias Clasen [Sat, 11 Apr 2020 20:24:05 +0000 (16:24 -0400)]
broadway: Fix the build

We need to depend on gdkenum_h, since we are (indirectly)
including gdkenumtypes.h in the broadway server build.

6 years agoMerge branch 'jjardon/more_licenses' into 'master'
Matthias Clasen [Sat, 11 Apr 2020 16:47:32 +0000 (16:47 +0000)]
Merge branch 'jjardon/more_licenses' into 'master'

gtk/gtkaboutdialog: Add some more very common licenses:

See merge request GNOME/gtk!1667

6 years agogtk/gtkaboutdialog: Add some more very common licenses:
Javier Jardón [Sat, 11 Apr 2020 15:49:09 +0000 (16:49 +0100)]
gtk/gtkaboutdialog: Add some more very common licenses:

- BSD 3-Clause "New" or "Revised" license
- Apache License 2.0
- Mozilla Public License 2.0

6 years agoMerge branch 'gsk-public-symbols' into 'master'
Emmanuele Bassi [Sat, 11 Apr 2020 15:21:11 +0000 (15:21 +0000)]
Merge branch 'gsk-public-symbols' into 'master'

Install all headers with public symbols

Closes #2607

See merge request GNOME/gtk!1666

6 years agoMerge branch 'action-docs' into 'master'
Matthias Clasen [Sat, 11 Apr 2020 15:12:22 +0000 (15:12 +0000)]
Merge branch 'action-docs' into 'master'

Action docs

See merge request GNOME/gtk!1665

6 years agoConditionally include the GSK broadway and vulkan symbols
Emmanuele Bassi [Sat, 11 Apr 2020 14:42:51 +0000 (15:42 +0100)]
Conditionally include the GSK broadway and vulkan symbols

In case GTK is built without these features.

6 years agoRevert "Do not install GSK headers for missing backends"
Emmanuele Bassi [Sat, 11 Apr 2020 14:41:47 +0000 (15:41 +0100)]
Revert "Do not install GSK headers for missing backends"

This reverts commit cd5cded430c37fcb57d0ecc03f8fdf2fdbe12c54.

The headers are public, but the symbols availability is conditional on
the GTK build.

6 years agoDocument actions
Matthias Clasen [Sat, 11 Apr 2020 03:59:21 +0000 (23:59 -0400)]
Document actions

6 years agogdk: Small documentation fixes
Matthias Clasen [Sat, 11 Apr 2020 01:13:38 +0000 (21:13 -0400)]
gdk: Small documentation fixes

6 years agotestsuite: Make actions test order-independent
Matthias Clasen [Sat, 11 Apr 2020 14:06:18 +0000 (10:06 -0400)]
testsuite: Make actions test order-independent

We only want to check that the actions are what we
expect, not that they are registered in a particular
order.

6 years agoMerge branch 'respect-window-cursors' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 18:56:44 +0000 (18:56 +0000)]
Merge branch 'respect-window-cursors' into 'master'

window: Respect widget cursors

See merge request GNOME/gtk!1663

6 years agowindow: Respect widget cursors
Matthias Clasen [Fri, 10 Apr 2020 18:35:02 +0000 (14:35 -0400)]
window: Respect widget cursors

gtk_widget_set_cursor can be used on a GtkWindow; we
should not blow away the result when temporarily installing
resize cursors.

6 years agoMerge branch 'remove-style-reset' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 17:36:03 +0000 (17:36 +0000)]
Merge branch 'remove-style-reset' into 'master'

Remove gtk_style_context_reset_widgets

See merge request GNOME/gtk!1662

6 years agoRemove gtk_style_context_reset_widgets
Matthias Clasen [Fri, 10 Apr 2020 16:45:28 +0000 (12:45 -0400)]
Remove gtk_style_context_reset_widgets

This should never be necessary to call from the outside.
Whenever we fail to update styles properly, it is a bug.

6 years agoMerge branch 'reduce-style-context-use' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 16:43:05 +0000 (16:43 +0000)]
Merge branch 'reduce-style-context-use' into 'master'

Use gtk_widget_add/remove_css_class more

See merge request GNOME/gtk!1661

6 years agoUse gtk_widget_add/remove_css_class more
Matthias Clasen [Fri, 10 Apr 2020 16:08:16 +0000 (12:08 -0400)]
Use gtk_widget_add/remove_css_class more

Replace most uses of gtk_style_context_add/remove_class
by the new APIs. The only remaining uses of the old API
are in save/restore situations.

6 years agoMerge branch 'fix-accel-length' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 13:27:07 +0000 (13:27 +0000)]
Merge branch 'fix-accel-length' into 'master'

accelgroup: Fix an invalid write

Closes #2602

See merge request GNOME/gtk!1660

6 years agoaccelgroup: Fix an invalid write
Matthias Clasen [Fri, 10 Apr 2020 12:24:03 +0000 (08:24 -0400)]
accelgroup: Fix an invalid write

This was lost by accident in d110fddbce14d13c.

Fixes: #2602
6 years agoUpdate POTFILES.in and POTFILES.skip
Piotr Drąg [Fri, 10 Apr 2020 11:56:58 +0000 (13:56 +0200)]
Update POTFILES.in and POTFILES.skip

6 years agoMerge branch 'fix-radiobuttons' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 04:17:37 +0000 (04:17 +0000)]
Merge branch 'fix-radiobuttons' into 'master'

radiobutton: Fix selection on focus-in

Closes #2326

See merge request GNOME/gtk!1658

6 years agoMerge branch 'popover-initial-focus' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 04:17:15 +0000 (04:17 +0000)]
Merge branch 'popover-initial-focus' into 'master'

Popover initial focus

See merge request GNOME/gtk!1657

6 years agoradiobutton: Fix selection on focus-in
Matthias Clasen [Fri, 10 Apr 2020 02:38:30 +0000 (22:38 -0400)]
radiobutton: Fix selection on focus-in

We need to unselect the previously selected button
to preserve radioness.

Fixes: #2326
6 years agomodelbutton: Catch focus-in more carefully
Matthias Clasen [Fri, 10 Apr 2020 02:22:28 +0000 (22:22 -0400)]
modelbutton: Catch focus-in more carefully

We need to unset the propagation limit on the focus
controller, else we miss the focus-in when the focus
enters the popover upon initial popup, when it comes
from the parent button.

6 years agopopovermenu: Remove debug spew
Matthias Clasen [Fri, 10 Apr 2020 01:41:02 +0000 (21:41 -0400)]
popovermenu: Remove debug spew

6 years agoMerge branch 'label-double-focus' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 01:34:49 +0000 (01:34 +0000)]
Merge branch 'label-double-focus' into 'master'

Avoid double focus in labels

Closes #135

See merge request GNOME/gtk!1656

6 years agoMerge branch 'scale-button-double-focus' into 'master'
Matthias Clasen [Fri, 10 Apr 2020 01:21:25 +0000 (01:21 +0000)]
Merge branch 'scale-button-double-focus' into 'master'

scalebutton: Don't derive from GtkButton

See merge request GNOME/gtk!1655